This repository was archived by the owner on Mar 10, 2020. It is now read-only.
port examples to new api #1222
Merged
port examples to new api #1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
suggested changes
Jan 21, 2020
alanshaw
force-pushed
the
refactor/async-iterables2
branch
2 times, most recently
from
08425af to
a27302d
Compare
Contributor
|
@hugomrdias would you mind rebasing this so I can look at just your changes? |
doesnt support imports
Co-Authored-By: Alan Shaw <alan.shaw@protocol.ai>
Co-Authored-By: Alan Shaw <alan.shaw@protocol.ai>
Co-Authored-By: Alan Shaw <alan.shaw@protocol.ai>
Co-Authored-By: Alan Shaw <alan.shaw@protocol.ai>
Co-Authored-By: Alan Shaw <alan.shaw@protocol.ai>
hugomrdias
force-pushed
the
refactor/async-iterables2-examples
branch
from
e79bd13 to
ffaaee9
Compare
Contributor
Author
|
done |
alanshaw
suggested changes
Feb 3, 2020
Contributor
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
Changes LGTM but why have you removed the browserify example?
Contributor
Author
|
browserify doesn't support deps that use esm. |
Collaborator
|
Could we use something like this to support esm in browserify? https://github.com/mattdesl/esmify |
Contributor
Contributor
|
I'm going to merge this so that we have up to date examples for the official release and open an issue so that we can get a browserify example re-added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.